Vamsi-klu commented on PR #70088: URL: https://github.com/apache/airflow/pull/70088#issuecomment-5087599073
@moomindani, thanks for the thorough review and for validating the lifecycle behavior against a real workspace. I pushed `c6f018d` and addressed all four inline comments: - Start polling now treats a `STOPPED` response immediately after the start request as potentially stale and continues until `RUNNING`, deletion, or timeout. The regression test covers `STOPPED` pre-check → start request → stale `STOPPED` poll → `RUNNING`. - The shared polling path now uses `WarehouseState.is_deleted` as the source of truth for terminal deletion states. - Hook construction is inlined into the cached `_hook` property. - The unused `ENV_ID` assignment is removed from the system-test example. I also corrected the PR description's timeout wording: no new poll starts after the deadline, while a target or deletion state returned by an already-started poll is still honored. On deferrable execution: I agree it would be valuable, but I am deliberately keeping it in Phase 2 rather than broadening this Phase 1 PR. That scope was recorded on #21377 and in the PR description before implementation. Since the warehouse start/stop endpoints return immediately, a future deferrable path can remain additive while preserving `wait_for_termination`, `polling_period_seconds`, and `timeout`. That follow-up will need the async state hook, serialized trigger and timeout behavior, operator completion path, and compatibility tests. If a committer considers deferrable execution a pre-merge requirement, I can revisit the scope here. Validation on the rebased branch: - Full Databricks provider suite: `842 passed, 12 skipped`. - Focused operator and warehouse-hook suites: `35 passed`. - System-test example: `1 test collected`. - Provider mypy: `Success: no issues found`. - Branch-level pre-commit and manual `prek` checks: passed. --- Drafted-by: Codex (GPT-5); reviewed by @Vamsi-klu before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
