mitre88 commented on PR #70482:
URL: https://github.com/apache/airflow/pull/70482#issuecomment-5087679308
Thanks for the review! Added
`test_templated_source_passes_validation_after_rendering`: the operator is
constructed with `source="{{ var.value.appflow_source }}"` (which raised
`ValueError` at parse time before this change) and executes successfully once
the field holds the rendered value. Verified the new test fails against the
previous implementation and passes with this one.
One note on scope: the `AppflowRun{Full,Before,After,Daily}Operator`
subclasses still have their own `source`/`filter_date` checks in `__init__`
(they are not in the exemption list since they inherit `template_fields` rather
than declaring them), so a templated `source` still fails at parse time through
those. Happy to move those in a follow-up PR if that is welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
