korex-f commented on PR #66633: URL: https://github.com/apache/airflow/pull/66633#issuecomment-5089383379
> Thank you for the update. > > > is there a failure mode left that the three merged PRs don't cover? > > Yes `log.py reorder (Bug 1): getattr(remote, "processors") was called before dictConfig ran, which meant dictConfig's _clearExistingHandlers closed the just-built watchtower handler before any task log was emitted.` statement is correct. > > I'd like to keep the only the `log.py` changes as that is the key point to resolve the unexpected `.close` on logging handler. The `supervisors.py` change is more "nice to have" but it _might_ introduce further regression. Let's keep the change minimal if possible, thanks. Thanks for the clarity. Reverting all supervisor.py changes now, this PR will only contain the log.py reorder (Bug 1). supervisor.py can be revisited in a follow-up if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
