onlyarnav commented on code in PR #70130:
URL: https://github.com/apache/airflow/pull/70130#discussion_r3656967557
##########
providers/databricks/tests/unit/databricks/operators/test_databricks.py:
##########
@@ -2925,6 +2925,28 @@ def
test_run_now_does_not_override_existing_job_parameters(self, db_mock_class):
actual = db_mock.run_now.call_args.args[0]
assert actual["job_parameters"] == {"explicit": "value"}
+
@mock.patch("airflow.providers.databricks.operators.databricks.DatabricksHook")
+ def
test_run_now_does_not_inject_airflow_params_when_forward_dag_params_is_false(self,
db_mock_class):
Review Comment:
Done! I've added a parametrized test
test_run_now_skips_param_injection_with_legacy_param_slots covering all 6
conflicting parameter slots to verify that job_parameters is not injected when
any of them are present
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
