dsuhinin commented on code in PR #68393:
URL: https://github.com/apache/airflow/pull/68393#discussion_r3658954162
##########
shared/observability/src/airflow_shared/observability/traces/__init__.py:
##########
@@ -229,15 +231,32 @@ def _get_backcompat_config(conf: ConfigParser) ->
tuple[str | None, Resource | N
def _load_exporter_from_env() -> SpanExporter:
"""
- Load a span exporter using the OTEL_TRACES_EXPORTER env var.
+ Pick a span exporter per the OTel SDK environment-variable spec.
+
+ ``OTEL_TRACES_EXPORTER`` selects the backend (``otlp`` default; ``console``
+ for debugging; ``zipkin`` or custom values are looked up via entry points).
+ For ``otlp``, ``OTEL_EXPORTER_OTLP_TRACES_PROTOCOL`` then
+ ``OTEL_EXPORTER_OTLP_PROTOCOL`` selects the transport: ``http/protobuf``
+ (default) or ``grpc``.
- Mirrors the entry-point mechanism used by the OTEL SDK auto-instrumentation
- configurator. Supported values (from installed packages):
- - ``otlp`` (default) — OTLP/gRPC
- - ``otlp_proto_http`` — OTLP/HTTP
- - ``console`` — stdout (useful for debugging)
+ See:
+
https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/#exporter-selection
+
https://opentelemetry.io/docs/specs/otel/protocol/exporter/#specify-protocol
"""
exporter_name = os.environ.get("OTEL_TRACES_EXPORTER", "otlp")
+ if exporter_name == "otlp":
Review Comment:
already added a `newsfragment`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
