ozemin commented on code in PR #70218:
URL: https://github.com/apache/airflow/pull/70218#discussion_r3660020382
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/quicksight.py:
##########
@@ -71,22 +82,73 @@ def __init__(
ingestion_id: str,
ingestion_type: str = "FULL_REFRESH",
wait_for_completion: bool = True,
- check_interval: int = 30,
+ waiter_delay: int = 30,
+ waiter_max_attempts: int = 60,
+ check_interval: int | None = None,
+ deferrable: bool = conf.getboolean("operators", "default_deferrable",
fallback=False),
**kwargs,
):
super().__init__(**kwargs)
+ if check_interval is not None:
Review Comment:
The default is `None`, so the warning only fires when `check_interval` is
passed
explicitly. It's a few lines above the context collapsed here:
https://github.com/apache/airflow/blob/29658c9ec0f28caf97cc466cffb9f7a1c818799f/providers/amazon/src/airflow/providers/amazon/aws/operators/quicksight.py#L87-L99
Happy to change it if you meant something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
