shivaam commented on code in PR #69728:
URL: https://github.com/apache/airflow/pull/69728#discussion_r3662056803


##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/dags.py:
##########
@@ -124,6 +124,10 @@ def get_dags(
     is_favorite: QueryFavoriteFilter,
     has_asset_schedule: QueryHasAssetScheduleFilter,
     asset_dependency: QueryAssetDependencyFilter,
+    timetable_type: Annotated[
+        FilterParam[list[str] | None],
+        Depends(filter_param_factory(DagModel.timetable_type, list[str], 
FilterOptionEnum.IN)),

Review Comment:
   Do you think consolidating these filters into the main Dag search could be 
handled in a separate PR, or would you prefer that we address it here?
   
   I think we can do a unified, GitHub-style search. It will benefit from a few 
design iterations to define the filter syntax, dropdown behavior, and how the 
existing filters should migrate. I’m happy to explore that separately while 
keeping this PR focused on timetable filtering.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to