amoghrajesh opened a new pull request, #70581:
URL: https://github.com/apache/airflow/pull/70581
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
closes: #70398
### Why?
Deferred `DbtCloudRunJobOperator` tasks failed within seconds of deferring
with a misleading `DbtCloudJobRunException: Job run <id> has failed`, even
though the dbt Cloud job kept running and completed successfully hours later.
### What
`DbtCloudHook.get_headers_tenants_from_connection()` and `get_job_details()`
resolved the connection through the hook's synchronous `connection`
cached_property while running inside the triggerer's live event loop. That
path masks the connection's secret via a synchronous comms call, which
`asgiref` rejects when called from a thread already running an event loop the
resulting `RuntimeError` propagated up through the trigger and was surfaced by
the operator as a job failure instead of the real (transient) error it was.
Both call sites now resolve the connection through the existing async safe
`get_async_connection()` helper, sharing a cache slot with the sync
`connection` cached_property so neither path performs a duplicate connection
lookup. Also switched the file's `Connection` type import to the
`airflow.providers.common.compat.sdk` compat shim (matching what
`get_connection()`/`get_async_connection()` actually return under Airflow
3), which let a stale `# type: ignore[return-value]` on the `connection`
property be removed.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
