kacpermuda opened a new pull request, #70626:
URL: https://github.com/apache/airflow/pull/70626
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
Fixes a set of paths in the OpenLineage listener where a single failing
detail discards an entire event, or escapes into the caller.
The headline is the team_name attr accessed with DagBundleModel, that was
trying to access the DB from the worker. Now it short-circuits to the team_name
in DagRun model, that is forwarded to workers.
| Fix | Impact before |
| --- | --- |
| `team_name` reads the Execution API value on workers | All task events
dropped when `multi_team` is on |
| Forked emission child always exits | A `BaseException` (e.g. SIGINT to the
process group) unwound the child back into the task runner, where it kept
running as a second one sharing the supervisor connection |
| `before_stopping` detaches the pool and guards its timeout | Every Dag run
event after a job stopped hit an already-shut-down pool; a hung shutdown raised
`AirflowTaskTimeout` (a `BaseException`) straight past the caller's `except
Exception` |
| `before_stopping` no longer creates a pool to tear down | The task runner
built a `ProcessPoolExecutor` at the end of every task purely to shut it down |
| `submit_callable` catches `RuntimeError` | `BrokenProcessPool` subclasses
it, so this also covers post-shutdown submissions |
| `get_airflow_state_run_facet` guards its DB query | A DB hiccup in the
pool worker discarded the whole terminal Dag run event instead of just the
facet |
| `dag_version_info` uses `safe_getattr` | Lazy-loaded `DagVersion` columns
could raise on a detached session |
| Pool wrappers no longer return the event | An unpicklable redacted event
reported a successful emission as a failed submission |
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 5)
Generated-by: Claude Code (Opus 5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
