[ 
https://issues.apache.org/jira/browse/AIRFLOW-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008931#comment-17008931
 ] 

ASF GitHub Bot commented on AIRFLOW-6487:
-----------------------------------------

Gabriel39 commented on pull request #7079: AIRFLOW-6487: Romove unnecessary 
for-loop
URL: https://github.com/apache/airflow/pull/7079
 
 
   ---
   Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6487
   Romove unnecessary for loop:
   
   In DagFileProcessorManager, dag files are processed periodically. Processor 
manager will put dag into queue except file_paths_in_progress, 
file_paths_recently_processed and files_paths_at_run_limit. While 
min_file_process_interval = 0 and num_runs = -1 in config by default, there is 
unnecessary for-loop when get file_paths_recently_processed and 
files_paths_at_run_limit.
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = 
JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with 
`[AIRFLOW-XXXX]`.
   
   ---
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Romove unnecessary for loop
> ---------------------------
>
>                 Key: AIRFLOW-6487
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6487
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: master
>            Reporter: Wenqiang Li
>            Assignee: Wenqiang Li
>            Priority: Major
>
> Romove unnecessary for loop:
> In DagFileProcessorManager, dag files are processed periodically. Processor 
> manager will put dag into queue except file_paths_in_progress, 
> file_paths_recently_processed and files_paths_at_run_limit. While 
> min_file_process_interval = 0 and num_runs = -1 in config by default, there 
> is unnecessary for-loop when get file_paths_recently_processed and 
> files_paths_at_run_limit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to