WonYong-Jang commented on code in PR #70427:
URL: https://github.com/apache/airflow/pull/70427#discussion_r3670745828
##########
airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/runOnLatestVersion.test.ts:
##########
@@ -22,11 +22,20 @@ import { getRunOnLatestVersionState } from
"./runOnLatestVersion";
describe("getRunOnLatestVersionState", () => {
it.each([
+ {
+ expectedDagVersionsDiffer: true,
+ expectedShouldShowRunOnLatestOption: false,
+ latestDagVersionNumber: 3,
+ name: "does not show when DAG versions differ but no bundle version is
present (non-versioned bundle)",
Review Comment:
Done - updated all "DAG" occurrences in these test names to "Dag".
Thank you for your guide.
##########
airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/runOnLatestVersion.test.ts:
##########
@@ -22,11 +22,20 @@ import { getRunOnLatestVersionState } from
"./runOnLatestVersion";
describe("getRunOnLatestVersionState", () => {
it.each([
+ {
+ expectedDagVersionsDiffer: true,
+ expectedShouldShowRunOnLatestOption: false,
+ latestDagVersionNumber: 3,
+ name: "does not show when DAG versions differ but no bundle version is
present (non-versioned bundle)",
+ selectedDagVersionNumber: 2,
+ },
{
expectedDagVersionsDiffer: true,
expectedShouldShowRunOnLatestOption: true,
+ latestBundleVersion: "bundle-b",
latestDagVersionNumber: 3,
- name: "shows and defaults on when DAG version numbers differ",
+ name: "shows when DAG versions differ on a versioned bundle even if the
run has no recorded bundle version",
Review Comment:
Fixed here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
