Aaryan123456679 commented on PR #70238: URL: https://github.com/apache/airflow/pull/70238#issuecomment-5113500409
@Miretpl All the review feedback above has been addressed in d971b4fec7: - Fixed the wording in `_helpers.yaml` and unified `airflowPodSecurityContextsIds`'s argument order with the other security-context helpers (updating its caller in `worker-deployment.yaml` accordingly). - Reworded the newsfragment, switched it to `.significant.rst`, and added a note that the `disableDefaults: false` default is deprecated and will flip to `true` in a future release — mirrored in `NOTES.txt`, `values.yaml`, and `values.schema.json`. - Added test coverage for `disableDefaults` on the pod-template-file path (`test_pod_template_file.py`) and for a component-level `securityContexts` override taking priority over a global `disableDefaults: true` (`test_security_context.py`). All Helm test suites (`security`, `airflow_aux`) pass. Could you take another look when you have a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
