uranusjr commented on code in PR #69695:
URL: https://github.com/apache/airflow/pull/69695#discussion_r3673327610
##########
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:
##########
@@ -67,21 +67,36 @@ def __init__(self, *args, sqlalchemy_scheme: str | None =
None, **kwargs) -> Non
self.schema = kwargs.pop("schema", None)
self._sqlalchemy_scheme = sqlalchemy_scheme
+ @staticmethod
+ def _validate_query_params(parameters: Iterable | Mapping[str, Any] |
None) -> dict[str, Any] | None:
+ """
+ Validate that query parameters are a dict, as required by pyexasol.
+
+ :param parameters: The parameters as passed to this hook's public
methods.
+ :return: The same parameters, narrowed to ``dict[str, Any] | None``
for pyexasol/mypy.
+ """
+ if parameters is not None and not isinstance(parameters, dict):
Review Comment:
This rejects any mapping _but_ a dict. This is probably not necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
