xBis7 commented on PR #70517: URL: https://github.com/apache/airflow/pull/70517#issuecomment-5117563532
Having configured all of the options `host`, `port` and `socket_path` isn't fatal. For datadog, the same class accepts all of them and then silently gives precedence to the `socket_path`. For statsd, each config option is used for a different class but all of them which could co-exist. In that case, the same metric will be emitted twice which isn't optimal or desired but still there won't be an issue for the system. IMO, we shouldn't set `host` and `port` to None when `socket_path` is also provided. For statsd, we should just give precedence to the `socket_path` and log a warning while for datadog, we should just log a warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
