Lee-W commented on code in PR #70498:
URL: https://github.com/apache/airflow/pull/70498#discussion_r3674876364
##########
registry/src/_data/exploreCategories.js:
##########
@@ -31,31 +31,31 @@ module.exports = [
name: 'Databases',
icon: '<svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path
stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M4 7v10c0
2.21 3.582 4 8 4s8-1.79 8-4V7M4 7c0 2.21 3.582 4 8 4s8-1.79 8-4M4 7c0-2.21
3.582-4 8-4s8 1.79 8 4" /></svg>',
color: 'blue',
- keywords: ['postgres', 'mysql', 'mongo', 'redis', 'neo4j',
'elasticsearch', 'cassandra', 'couchbase', 'influxdb', 'sqlite', 'odbc',
'jdbc', 'common-sql'],
+ keywords: ['postgres', 'mysql', 'mongo', 'redis', 'neo4j',
'elasticsearch', 'cassandra', 'couchbase', 'influxdb', 'sqlite', 'odbc',
'jdbc', 'common-sql', 'mssql', 'opensearch', 'cloudant', 'arangodb'],
description: 'SQL, NoSQL, and time-series databases',
},
{
id: 'data-warehouses',
name: 'Data Warehouses',
icon: '<svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path
stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M19 11H5m14
0a2 2 0 012 2v6a2 2 0 01-2 2H5a2 2 0 01-2-2v-6a2 2 0 012-2m14 0V9a2 2 0
00-2-2M5 11V9a2 2 0 012-2m0 0V5a2 2 0 012-2h6a2 2 0 012 2v2M7 7h10" /></svg>',
color: 'purple',
- keywords: ['snowflake', 'databricks', 'teradata', 'vertica', 'trino',
'presto', 'dbt'],
+ keywords: ['snowflake', 'databricks', 'teradata', 'vertica', 'trino',
'presto', 'dbt', 'exasol', 'clickhouse'],
description: 'Snowflake, Databricks, and analytics platforms',
},
{
id: 'messaging',
name: 'Messaging & Notifications',
icon: '<svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path
stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M8 12h.01M12
12h.01M16 12h.01M21 12c0 4.418-4.03 8-9 8a9.863 9.863 0 01-4.255-.949L3
20l1.395-3.72C3.512 15.042 3 13.574 3 12c0-4.418 4.03-8 9-8s9 3.582 9 8z"
/></svg>',
color: 'green',
- keywords: ['slack', 'sendgrid', 'smtp', 'discord', 'telegram',
'pagerduty', 'opsgenie', 'twilio'],
+ keywords: ['slack', 'sendgrid', 'smtp', 'discord', 'telegram',
'pagerduty', 'opsgenie', 'twilio', 'dingtalk', 'apprise'],
description: 'Slack, email, SMS, and alerting services',
},
{
id: 'ai-ml',
name: 'AI & Machine Learning',
icon: '<svg fill="none" stroke="currentColor" viewBox="0 0 24 24"><path
stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M9.663
17h4.673M12 3v1m6.364 1.636l-.707.707M21 12h-1M4
12H3m3.343-5.657l-.707-.707m2.828 9.9a5 5 0 117.072 0l-.548.547A3.374 3.374 0
0014 18.469V19a2 2 0 11-4 0v-.531c0-.895-.356-1.754-.988-2.386l-.548-.547z"
/></svg>',
color: 'amber',
- keywords: ['openai', 'cohere', 'anthropic', 'huggingface', 'mlflow',
'pinecone', 'qdrant', 'weaviate', 'pgvector'],
+ keywords: ['openai', 'cohere', 'anthropic', 'huggingface', 'mlflow',
'pinecone', 'qdrant', 'weaviate', 'pgvector', 'langchain', 'llamaindex', 'mcp',
'pydantic ai', 'pydantic-ai'],
Review Comment:
Agreed — removed, and `fuzzyIncludes` normalizes now.
##########
registry/src/_data/providerCategoryMap.js:
##########
@@ -19,14 +19,15 @@
const providersData = require("./providers.json");
const exploreCategories = require("./exploreCategories");
+const { providerMatchesKeyword } = require("./providerKeywordMatch");
module.exports = function () {
const map = {};
for (const provider of providersData.providers) {
const cats = [];
for (const category of exploreCategories) {
for (const keyword of category.keywords) {
- if (provider.id.includes(keyword) || keyword.includes(provider.id)) {
+ if (providerMatchesKeyword(provider, keyword)) {
Review Comment:
`providers.njk` now emits the integration names as `data-integrations` and
`matchesSearch` tests it, so "langchain" hits on /providers/.
<img width="2312" height="770" alt="image"
src="https://github.com/user-attachments/assets/5dcc8ce3-817d-4b20-880d-ad42329f7607";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
