1fanwang commented on code in PR #66405:
URL: https://github.com/apache/airflow/pull/66405#discussion_r3678862716
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -1467,6 +1468,9 @@ def process_executor_events(
job_id,
)
state, info = event_buffer.pop(buffer_key)
+ # Pop unconditionally, not only on the killed-externally branch
below, so a
+ # self-reporting task can't leak its entry.
+ executor_failure_kind = executor.get_task_failure_info(ti.key)
Review Comment:
type hint where initialized pls, so hard to read otherwise
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -1467,6 +1468,9 @@ def process_executor_events(
job_id,
)
state, info = event_buffer.pop(buffer_key)
+ # Pop unconditionally, not only on the killed-externally branch
below, so a
+ # self-reporting task can't leak its entry.
+ executor_failure_kind = executor.get_task_failure_info(ti.key)
Review Comment:
type hint where initialized pls, so hard to read otherwise, same for other
places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
