potiuk commented on code in PR #69078:
URL: https://github.com/apache/airflow/pull/69078#discussion_r3682263412
##########
shared/observability/src/airflow_shared/observability/metrics/metrics_template.yaml:
##########
@@ -226,6 +226,13 @@ metrics:
legacy_name: "-"
name_variables: []
+ - name: "dag.auto_paused"
Review Comment:
The declaration doesn't match what the code actually emits. `stats.incr(...,
tags=self.stats_tags)` uses `DagRun.stats_tags`, which carries **both `dag_id`
and `run_type`** — but this entry says `name_variables: []` and the description
mentions only "dag_id tagging".
For comparison, #70013 declares its tagged gauges as `name_variables:
["dag_id"]` with a matching `legacy_name`. Worth being consistent: either list
both variables here with an appropriate `legacy_name`, or narrow the emission
to `{"dag_id": self.dag_id}` if `run_type` isn't wanted on this counter. Given
it counts a Dag-level event rather than a run-level one, dropping `run_type`
may actually be the cleaner answer.
Also minor: the description's second line starts at the same indentation as
the key, which makes it a slightly odd multi-line plain scalar. Indenting the
continuation under `description:` reads better and matches the surrounding
entries.
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
