potiuk commented on code in PR #70347:
URL: https://github.com/apache/airflow/pull/70347#discussion_r3682309808
##########
providers/microsoft/psrp/src/airflow/providers/microsoft/psrp/operators/psrp.py:
##########
@@ -56,8 +56,7 @@ class PsrpOperator(BaseOperator):
:param command: command to execute on remote host. (templated)
:param powershell: powershell to execute on remote host. (templated)
:param cmdlet:
- cmdlet to execute on remote host (templated). Also used as the default
- value for `task_id`.
+ cmdlet to execute on remote host (templated).
Review Comment:
This docstring edit is the visible half of the behaviour change — dropping
"Also used as the default value for `task_id`" alongside removing the
`setdefault`.
Documenting it here is right, but a docstring is not where users find out
that their task_ids changed. That needs the newsfragment/changelog entry
described in the review body.
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
