rjgoyln opened a new pull request, #70758:
URL: https://github.com/apache/airflow/pull/70758
## Summary
Airflow uses a custom OpenTelemetry `IdGenerator` so spans from DAG runs and
task runs
share the same trace. Previously, this generator was only applied when
Airflow created
the `TracerProvider`, so deployments using auto-instrumentation or vendor
distros lost
trace linkage.
This change registers the generator as a standard OpenTelemetry entry point,
allowing it
to be enabled with `OTEL_PYTHON_ID_GENERATOR=airflow`, and adds a fallback
that patches
an existing `TracerProvider` when possible.
## Changes
- Register `OverrideableRandomIdGenerator` as an
`opentelemetry_id_generator` entry point.
- Add a fallback in `configure_otel()` to patch an existing
`TracerProvider` and emit a warning.
- Document auto-instrumentation usage and fallback behavior.
- Add tests for entry point registration and fallback.
- Add newsfragment: `70388.improvement.rst`.
## Notes
- The entry point is registered only in `airflow-core`, since only it
overrides span IDs.
- Workers receive propagated `traceparent` values and do not need ID
overrides.
## Scope
This PR addresses **Issue 1** of #70388 only. Issues 2 and 3 remain for
future work.
* related: #70388
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
