potiuk commented on PR #69397:
URL: https://github.com/apache/airflow/pull/69397#issuecomment-5131417202
Heads-up: I merged #69274 earlier today and it has just put this PR into
conflict — apologies, the overlap wasn't obvious until I re-read both.
#69274 marked the `tasks` CLI commands as migrated, which included adding
exactly the two things this PR also adds:
- `@deprecated_for_airflowctl("airflowctl tasks failed-deps")` on
`task_failed_deps` in `airflow-core/src/airflow/cli/commands/task_command.py`
(now on `main` at line 265)
- the matching `(task_command.task_failed_deps, "airflowctl tasks
failed-deps")` entry in `test_command_deprecations.py`
This branch is ~168 commits behind `main`, so on rebase both will collide.
The resolution is simply to **drop them from this PR** — they're already on
`main`; the rest of the change is unaffected.
On the implementation itself, which I reviewed properly: it looks good. The
exactly-one guard on `run_id` / `--logical-date` is right,
`_build_task_instance_path` handles the `map_index >= 0` case correctly against
the `-1` default, and the fallback that fetches the task instance to explain an
empty dependency list — rather than implying "all dependencies met" — is a
genuinely thoughtful touch that most CLI commands skip.
No further review comments from me; just the rebase.
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
