SameerMesiah97 commented on code in PR #69768:
URL: https://github.com/apache/airflow/pull/69768#discussion_r3683088594
##########
airflow-core/src/airflow/models/pool.py:
##########
@@ -121,6 +121,10 @@ def get_default_pool(*, session: Session = NEW_SESSION) ->
Pool | None:
"""
return Pool.get_pool(Pool.DEFAULT_POOL_NAME, session=session)
+ @staticmethod
+ def get_default_team_pool_name(team_name: str) -> str:
+ return f"default_pool_{team_name}"
Review Comment:
`team_name` is already validated in `_extract_team_name()`, so by the time
it reaches `get_default_team_pool_name()` it is guaranteed to match regx
`^[a-zA-Z0-9_-]{3,50}$`. So I do not see the need for additional validation for
`Team.name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
