aaron-y-chen commented on code in PR #70425:
URL: https://github.com/apache/airflow/pull/70425#discussion_r3687603797
##########
helm-tests/tests/helm_tests/airflow_aux/test_basic_helm_chart.py:
##########
@@ -384,35 +384,41 @@ def test_network_policies_are_valid(self,
airflow_version, executor):
"flower": {"enabled": True},
},
("flower-ingress", "Ingress", "flower-ingress"),
+ ("ingress", "Ingress", "airflow-ingress"),
[],
- id="flower-ingress",
+ id="ingress",
),
pytest.param(
{
- "ingress": {
- "web": {"enabled": True},
- "apiServer": {"enabled": True},
- },
+ "ingress": {"apiServer": {"enabled": True}},
Review Comment:
Got it. When I looked at this change, it followed the Flower pattern, so I
thought it was okay.
Please give me some time to think about it more deeply. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
