atikulmunna commented on PR #70723: URL: https://github.com/apache/airflow/pull/70723#issuecomment-5139895121
Thanks for the correction, and no need to apologise for the churn. You're right. I mirrored #70574 and treated it as settled precedent instead of checking it against the false positives section of #70296, which is exactly the failure mode you describe in your sweep. Rewritten in place: * the check stays in `__init__`, now `match_glob is not None` rather than the truthiness test * narrowed to `ValueError`, which also drops `AirflowException` from the `common.compat.sdk` import since nothing else in the file used it * the test asserts the raise at construction instead of from `execute()` * exemption entry still removed, and I confirmed `validate-operators-init` passes with it gone, so #70505 does what you said One thing that wasn't in your review: narrowing to `ValueError` removes this file's only `raise AirflowException`, which left a stale `gcs_to_s3.py::1` entry in `generated/known_airflow_exceptions.txt`. I dropped that too, same as #70359 did. Running `--cleanup` also wanted to remove an unrelated `mlengine.py` entry, which I put back so the diff stays on topic. Also worth correcting my own PR description: I said there I couldn't run the tests. I've since got them running in a Linux container and the file is green, 31 passed. The Windows blocker was `os.register_at_fork` in `_shared/observability/metrics/stats.py`, which is POSIX only, so it isn't something a local install can work around. The version probe stays in `__init__` untouched, since it depends on the installed provider rather than a rendered value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
