SamWheating commented on code in PR #70586:
URL: https://github.com/apache/airflow/pull/70586#discussion_r3690309022
##########
airflow-core/tests/unit/dag_processing/test_manager.py:
##########
@@ -1046,6 +1046,72 @@ def test_scan_stale_dags(self, session):
# SerializedDagModel gives history about Dags
assert serialized_dag_count == 1
+ @pytest.mark.usefixtures("testing_dag_bundle")
+ def test_scan_stale_dags_deactivates_zip_packaged_dags(self, session,
test_zip_path):
+ """
+ Ensure that zip-packaged DAGs are marked inactive when the file is
parsed but the
+ DagModel.last_parsed_time is not updated.
+ """
+ manager = DagFileProcessorManager(
+ max_runs=1,
+ processor_timeout=10 * 60,
+ )
+ bundle = MagicMock()
+ bundle.name = "testing"
+ manager._dag_bundles = [bundle]
+
+ test_dag_path = DagFileInfo(
+ rel_path=Path(test_zip_path),
+ bundle_name="testing",
+ )
+ dagbag = DagBag(
+ test_zip_path,
+ bundle_path=test_dag_path.bundle_path,
+ )
+
+ # Add stale DAG to the DB
+ dag = dagbag.get_dag("test_zip_dag")
+ sync_dag_to_db(dag, session=session)
+
+ # Add DAG to the file_parsing_stats
+ stat = DagFileStat(
+ num_dags=1,
+ import_errors=0,
+ last_finish_time=timezone.utcnow() + timedelta(hours=1),
+ last_duration=1,
+ run_count=1,
+ last_num_of_db_queries=1,
+ )
+ manager._files = [test_dag_path]
Review Comment:
> _files isn't an attribute the manager itself uses (only tests assign it)
Actually, maybe the other tests don't use it either 🤔 Will see if its safe
to remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
