rjgoyln opened a new pull request, #70841: URL: https://github.com/apache/airflow/pull/70841
## Summary `ServerResponseError.from_response()` parsed JSON from `5xx` responses before reading the body, causing `httpx.ResponseNotRead` in response hooks. This prevented the intended `ServerResponseError` from being raised and broke retries for server errors. ## Changes - Read the response body before handling `4xx`/`5xx` responses. - Format `5xx` JSON errors consistently with `4xx`. - Add a streaming-response test helper to reproduce unread-body behavior. - Add tests covering JSON `5xx` error parsing and retry behavior. ## Notes The JSON `5xx` path previously had no test coverage because existing tests used `text=` responses. The new tests fail on `main` with `httpx.ResponseNotRead`. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes (please specify the tool below) Generated-by: Claude Code (Opus 5) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
