bugraoz93 commented on code in PR #70869: URL: https://github.com/apache/airflow/pull/70869#discussion_r3692923145
########## providers/google/src/airflow/providers/google/cloud/secrets/secret_manager.py: ########## @@ -37,6 +38,10 @@ SECRET_ID_PATTERN = r"^[a-zA-Z0-9-_]*$" +# Separator between the team name and the secret id in a team scoped secret name. +# Matches the convention the other secrets backends use. +TEAM_SEP = "--" Review Comment: Good to import this from core in the future not a blocker -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
