potiuk commented on PR #70638:
URL: https://github.com/apache/airflow/pull/70638#issuecomment-5148888844
Thanks for picking this up, and sorry it's not the outcome you were hoping
for.
This change is a no-op. `aws_template_fields()` unions its arguments with a
fixed set that already contains `aws_conn_id`:
```python
return tuple(sorted({"aws_conn_id", "region_name", "verify"} |
set(template_fields)))
```
So the resulting tuple is byte-identical before and after:
```
('aws_conn_id', 'data', 'region_name', 's3_bucket', 's3_key', 'verify')
```
`S3CreateObjectOperator` already supports a templated `aws_conn_id` — every
operator built on `AwsBaseOperator` does. You can verify with the example from
#35259; passing `aws_conn_id="{{ params.aws_conn_id }}"` works on `main` today.
#35259 asks for templated connection ids across *all* third-party operators,
and Amazon is the provider where it already works. The remaining work is in the
providers that don't have an equivalent of `aws_template_fields` — that's where
a fix would land.
Closing this one, but the issue is still open and worth taking on from that
angle.
---
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
