Eason09053360 opened a new pull request, #70919:
URL: https://github.com/apache/airflow/pull/70919
`GoogleAnalyticsAdminCreatePropertyOperator` builds the property link ID with
`prop.name.lstrip("properties/")`. `str.lstrip` removes any leading character
belonging to the given set — it is not a prefix strip — so it also consumes
any
leading `p`, `r`, `o`, `e`, `t`, `i`, `s` or `/` of the property ID itself.
This is correct today only because GA4 property IDs are numeric, so there is
no
user-visible behaviour change. The intent is a prefix strip, so
`removeprefix`
expresses it directly and removes the latent trap.Improve semantics and
readability
The `persist` call had no test coverage; the added parametrized test pins the
exact-prefix semantics and fails on the previous implementation.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 5)
Generated-by: Claude Code (Opus 5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
