JH0917 commented on code in PR #68792:
URL: https://github.com/apache/airflow/pull/68792#discussion_r3698233367
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -720,6 +723,21 @@ def clean_unused(self) -> None:
"""Remove triggers that are no longer needed."""
Trigger.clean_unused()
+ def check_for_unhandled_triggers(self, num_running: int) -> None:
+ """
+ Shut down if the subprocess trigger count disagrees with the
supervisor.
+
+ Only valid between finished-removal and to_create-addition in
``_handle_request``.
+ """
+ expected = len(self.running_triggers)
+ if expected != num_running:
+ log.error(
Review Comment:
As far as I can see that log only carries logger_name="supervisor" --
nothing is bound to it anywhere on the path. So I left it as is: request
context rides on contextvars and shows up either way, and the difference would
be that this line gets tagged [supervisor] while the rest of the class logs as
[airflow.jobs.triggerer_job_runner]. Happy to be told I'm misreading it.
Drafted-by: Claude Code (Opus 5); reviewed by @JH0917 before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
