ColtenOuO commented on PR #70433:
URL: https://github.com/apache/airflow/pull/70433#issuecomment-5156727452
Thanks! agreed on base64, since it's the only option that can carry real
binary payloads without ever needing revisiting.
```python
bytes: {"type": "string", "contentEncoding": "base64"},
```
Decoding with `base64.b64decode(value, validate=True)`, `validate=True`
matters because the default silently discards invalid characters instead of
erroring, which is the same silent-corruption problem this PR is meant to fix.
I'll re-raise as a `ValueError` naming the parameter so the model gets a usable
retry message. No UTF-8 fallback on decode failure — that would put us back to
an undefined contract.
On the two smaller points: I'll narrow to `except (NameError, TypeError)`
with a comment on the `from __future__ import annotations` fallback issue, and
have `_build_json_schema_from_signature` return the bytes param names once,
cached per tool, instead of re-introspecting on every `call_tool`.
Happy to hold for `common.ai` maintainer input given this is provider-wide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
