Adityakk9031 commented on PR #69504: URL: https://github.com/apache/airflow/pull/69504#issuecomment-5159612966
Thank @potiuk you for the detailed review — the feedback is well-taken on all points. Done: Sentry fix only — the PR has been stripped down to exactly the 2 files you approved: sentry/configured.py (removing the dead if/else branch so conf.getimport runs unconditionally) and test_sentry.py (asserting resolved callables via import_string instead of raw strings). Branch is also rebased onto the latest main. Windows-compat work split out — the three unrelated changes (common_prek_utils.py encoding, os.register_at_fork guard, and the conftest platform handling) have been moved to a separate PR on branch windows-compat-fixes. The conftest approach has also been corrected per your inline comment — instead of installing a no-op fcntl stub, test_supervisor.py and test_task_runner.py now carry a pytestmark = pytest.mark.skipif(sys.platform == "win32", ...) so POSIX-dependent tests are skipped honestly on Windows and continue to run normally on Linux CI. This PR now only contains the Sentry bugfix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
