kaxil commented on code in PR #70883:
URL: https://github.com/apache/airflow/pull/70883#discussion_r3703119718
##########
task-sdk/src/airflow/sdk/execution_time/secrets_masker.py:
##########
@@ -31,8 +32,9 @@
from airflow.utils.deprecation_tools import DeprecatedImportWarning
warnings.warn(
- "Importing from 'airflow.sdk.execution_time.secrets_masker' is deprecated
and will be removed in a future version. "
- "Please use 'airflow.sdk._shared.secrets_masker' instead.",
+ "Importing from 'airflow.sdk.execution_time.secrets_masker' is deprecated
and will be removed in a future "
+ "version. Please use 'airflow.sdk._shared.secrets_masker' instead, EXCEPT
for 'mask_secret': that should be "
+ "imported from 'airflow.sdk.log' instead.",
Review Comment:
Nit, non-blocking: two "instead"s in one sentence, and the all-caps EXCEPT
reads a bit shouty. Could be said in one pass:
```suggestion
"Importing from 'airflow.sdk.execution_time.secrets_masker' is
deprecated and will be removed in a future "
"version. Please import 'mask_secret' from 'airflow.sdk.log' and
everything else from "
"'airflow.sdk._shared.secrets_masker'.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
