kaxil commented on code in PR #70497:
URL: https://github.com/apache/airflow/pull/70497#discussion_r3706908490
##########
providers/common/ai/provider.yaml:
##########
@@ -374,6 +391,13 @@ connection-types:
- hook-class-name: airflow.providers.common.ai.hooks.langchain.LangChainHook
hook-name: "LangChain"
connection-type: langchain
+ external-services:
Review Comment:
The three lists now apply three different rules to OpenAI-compatible
self-hosted endpoints: pydanticai gets Ollama, vLLM and LM Studio, llamaindex
gets Ollama and vLLM, langchain gets Ollama only. `langchain.py:55` documents
`host` as "custom endpoints, Ollama, vLLM" and `_connection_kwargs` passes it
through as `base_url` unchanged, so vLLM belongs here too (and in
`get_provider_info.py:313`). Worth settling whether LM Studio is in all three
or none, since it reaches the same surface.
##########
providers/common/ai/provider.yaml:
##########
@@ -147,6 +147,17 @@ connection-types:
- hook-class-name:
airflow.providers.common.ai.hooks.pydantic_ai.PydanticAIHook
hook-name: "Pydantic AI"
connection-type: pydanticai
+ external-services:
Review Comment:
This renders as a bare "External services" column, so it reads as the
complete set, but the base hook just maps `conn.password` to `api_key` for
whichever provider the model id names, and 27 of pydantic-ai's provider classes
take `api_key` at the version resolving today (Cohere, OpenRouter, Together,
Fireworks, Cerebras and HuggingFace among them). Ten listed out of 27 means a
reader concludes the rest are unsupported, and the list needs an edit every
time pydantic-ai adds a provider. Either label the column and the schema
description as representative rather than exhaustive, or keep enumerations for
the single-vendor types where they are complete by construction.
##########
registry/src/css/main.css:
##########
@@ -3556,6 +3556,40 @@ main {
border-color: var(--color-green-400);
}
+/* Per-connection upstream integration matrix */
Review Comment:
The rename did not reach the CSS: this comment still says "upstream
integration matrix" and the classes are
`conn-integrations-table/-header/-row/-list`, used at
`provider-version.njk:256-268`. They are new in this PR so nothing consumes
them yet, which makes renaming free now and dead-name debt later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
