bujjibabukatta commented on code in PR #70922:
URL: https://github.com/apache/airflow/pull/70922#discussion_r3715171395


##########
providers/google/src/airflow/providers/google/cloud/operators/dataproc.py:
##########
@@ -713,6 +718,7 @@ def __init__(
         **kwargs,
     ) -> None:
         # TODO: remove one day
+        self._legacy_cluster_kwargs: dict | None = None

Review Comment:
   @olegkachur-e Good point. They're deprecated but still around, so they 
should still work right until they're actually removed. Right now they don't — 
cluster_config gets built in __init__ before rendering happens, so any 
templated value just doesn't get filled in. This fix takes care of that in the 
meantime.
   
   If you'd rather I just remove the kwargs path instead of fixing it, I'm okay 
with that too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to