1fanwang commented on issue #70953:
URL: https://github.com/apache/airflow/issues/70953#issuecomment-5186703799

   Verified [Handle DockerOperator mounts after 
rendering](https://github.com/apache/airflow/pull/70342) on `docker 4.5.9rc1`. 
Works as intended.
   
   Airflow 3.3.0, two identical virtualenvs: one with the RC providers, one 
with the previous stable release. Same Dag, same command, run through the real 
task runner. Only the external transport is stubbed, and the stub asserts the 
value that actually reaches it.
   
   A `DockerOperator` with a mount whose source comes from a param. No docker 
daemon on this machine, so the API client is stubbed and asserts the mount 
handed to `create_host_config`.
   
   ```bash
   # docker 4.5.9rc1
   AIRFLOW_HOME=$PWD/airflow_home \
   AIRFLOW__CORE__DAGS_FOLDER=$PWD/dags_e2e/rc_70342_docker_mounts \
     .venv/bin/airflow dags test rc_70342_docker_mounts
   
   # docker 4.5.8, identical Dag
   AIRFLOW_HOME=$PWD/airflow_home_prev \
   AIRFLOW__CORE__DAGS_FOLDER=$PWD/dags_e2e/rc_70342_docker_mounts \
     .venv-prev/bin/airflow dags test rc_70342_docker_mounts
   ```
   
   ```
   # docker 4.5.9rc1
   MOUNTS_TO_DOCKER_PY=[{'Target': '/data', 'Source': '/tmp/rc-data', 'Type': 
'bind', 'ReadOnly': False}]
   state=success
   
   # docker 4.5.8
   MOUNTS_TO_DOCKER_PY=[{'Target': '/data', 'Source': '/tmp/rc-data', 'Type': 
'bind', 'ReadOnly': False}]
   state=success
   ```
   
   Identical on both, so this is a no-regression result.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to