bbovenzi commented on code in PR #70151:
URL: https://github.com/apache/airflow/pull/70151#discussion_r3729527073
##########
airflow-core/docs/ui.rst:
##########
@@ -229,6 +229,7 @@ The **Events** tab surfaces structured events related to
the Dag, such as Dag tr
.. image:: img/ui-light/dag_overview_events.png
:alt: Dag Events Tab (Light Mode)
+
Review Comment:
```suggestion
```
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/backfills.py:
##########
@@ -52,6 +58,14 @@
def list_backfills_ui(
limit: QueryLimit,
offset: QueryOffset,
+ start_date_range: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("from_date", Backfill))],
+ end_date_range: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("to_date", Backfill))],
+ created_at: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("created_at", Backfill))],
+ completed_at: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("completed_at", Backfill))],
+ max_active_runs: Annotated[RangeFilter,
Depends(float_range_filter_factory("max_active_runs", Backfill))],
+ reprocess_behavior: Annotated[
+ FilterParam, Depends(filter_param_factory(Backfill.reprocess_behavior,
str | None))
Review Comment:
We should validate `reprocess_behavior` as `ReprocessBehavior` type.
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/backfills.py:
##########
@@ -39,6 +43,8 @@
from airflow.api_fastapi.core_api.security import ReadableBackfillsFilterDep,
requires_access_backfill
from airflow.models.backfill import Backfill
+log = logging.getLogger(__name__)
Review Comment:
```suggestion
```
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/backfills.py:
##########
@@ -16,6 +16,7 @@
# under the License.
from __future__ import annotations
+import logging
Review Comment:
```suggestion
```
##########
airflow-core/src/airflow/ui/src/pages/Dag/Backfills/BackfillsFilters.tsx:
##########
@@ -0,0 +1,47 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { VStack } from "@chakra-ui/react";
+
+import { FilterBar } from "src/components/FilterBar";
+import { SearchParamsKeys } from "src/constants/searchParams";
+import { useFiltersHandler, type FilterableSearchParamsKeys } from "src/utils";
+
+export const BackfillsFilters = () => {
+ const searchParamKeys: Array<FilterableSearchParamsKeys> = [
+ SearchParamsKeys.START_DATE_RANGE,
+ SearchParamsKeys.END_DATE_RANGE,
Review Comment:
We need to rename these `FROM_RANGE` and `TO_RANGE` in order to be
consistent with the backfill values and the table column names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
