mihirduvedi commented on PR #71318: URL: https://github.com/apache/airflow/pull/71318#issuecomment-5229271238
I checked this against `triggers/base.py` and your reading holds up. It filters `self.task.template_fields` down to the keys that appear in `start_trigger_args.trigger_kwargs` and also exist on the trigger (lines 115-137), then renders them in `render_template_fields()` at 142. The un-rendered Jinja in `trigger_kwargs` is what that filter keys on, so it has to be captured at parse time. One thing for the follow-up: narrowing the hook means the diagnostic in `_check_constructor_field_logic()` needs a third case. I wrote the current wording in #71210 and it only covers two: value-dependent reads and provision checks. --- Drafted-by: Claude (Opus 5); reviewed by @mihirduvedi before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
