kaxil commented on code in PR #68847:
URL: https://github.com/apache/airflow/pull/68847#discussion_r3745227690
##########
airflow-core/src/airflow/executors/base_executor.py:
##########
@@ -581,7 +581,7 @@ def terminate(self):
"""Get called when the daemon receives a SIGTERM."""
raise NotImplementedError
- def revoke_task(self, *, ti: TaskInstance):
+ def revoke_task(self, *, ti: TaskInstance) -> bool | None:
Review Comment:
There are a lot of unrelated changes like this which makes reviewing the PR
harder.
Could we restrict changes to SandboxToolset only first -- like what the PR
title says -- and have other things (Executor and such) in separate PRs please
@zozo123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
