potiuk opened a new pull request, #71431:
URL: https://github.com/apache/airflow/pull/71431
The provider tagging step relied on the release manager's checkout happening
to sit on the wave commit. `breeze release-management tag-providers` runs a
bare `git tag <name>`, so it tags whatever `HEAD` points at and never derives
the commit from `--release-date`. Nothing enforced or verified that, so
anything moving `HEAD` between the build and the tagging step - a pull, a
branch switch, a rebase, or concurrent work in a shared checkout - got tagged
silently, with no error to notice.
That is not hypothetical: in one wave all 44 provider tags were pushed at an
unrelated commit and had to be force-recreated afterwards.
Both `tag-providers` call sites in the release doc - the RC tags and the
final release tags - now check out the wave tag and assert the commit before
tagging:
```shell
git checkout providers/${RELEASE_DATE}
# Both SHAs printed here must be identical before you tag
git rev-parse HEAD "providers/${RELEASE_DATE}^{commit}"
breeze release-management tag-providers --release-date ${RELEASE_DATE}
```
Both sections also show how to verify the pushed tags afterwards. `git
ls-remote` prints the *tag object* SHA for annotated tags, which never equals
the commit and reads as a mismatch, so the check needs `^{}` to dereference it.
The full rationale lives at the RC-tags section; the final-tags section
links back to it rather than repeating it.
A stronger follow-up would be to make `tag-providers` resolve the commit
from `--release-date` itself (or accept `--ref`), so the tool cannot tag the
wrong commit even when the checkout step is skipped. This PR only fixes the
documented procedure.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 5)
Generated-by: Claude Code (Opus 5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
