potiuk commented on PR #71378: URL: https://github.com/apache/airflow/pull/71378#issuecomment-5255281422
> We can still update the lowest python version all at once when relaxed. but I'm not going to block this PR. Problem with relaxing is also that prek hooks are pretty "sensitive" to Python version - for example AST might have some changes, in different Python versions, or MyPY will work differently or. ...... (there were **multiple** cases in the past. And a bit of a problem here as well that this introduces "works-for-me" syndrom if people are using different Python versions in CI and locally - the `>=3.10.<3.11` has two properties: a) prevents this `works for me` b) uses "lowest-common-denominator" - which is the same as Python version - 3.10 **all** PRs use by default (vast majority of PRs use 3.10 builds only - with the assumption that breaking changes in our code are rare and will be detected in canary. Surely we **could** run prek hooks with 3.14 consistently as well (but then for example there will be a chance that they will not work in the breeze 3.10 image that is used in most tests - and in codespaces or other places where devcontainers are used - and people who use devcontainers run `prek` hooks inside their default CI image. c) it might also confuse people when to use and when not to use Python 3.14 syntax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
