pierrejeambrun opened a new pull request, #71443:
URL: https://github.com/apache/airflow/pull/71443

   The Asset Events table on the Run page renders its title as **"Source 
assetEvent_other"** instead of "Source Asset Events" (and the Task Instance one 
as "Created assetEvent_other").
   
   `Run/AssetEvents.tsx` passes `titleKey="common:sourceAssetEvent"` to the 
shared table (`components/Assets/AssetEvents.tsx`), whose 
`useTranslation(["dashboard", "common", "dag"])` defaults to the 
**`dashboard`** namespace. In `en/common.json` the key is 
`"sourceAssetEvent_other": "Source $t(assetEvent_other)"` — a nested reference 
introduced by the translation DRY refactor (#68285). The nested unqualified 
`$t(assetEvent_other)` resolves against the hook's default namespace 
(`dashboard`), where `assetEvent_other` doesn't exist, so it renders the raw 
key.
   
   Only `en` uses the nested form — all 20 other locales already have plain 
inline strings. This inlines the English `sourceAssetEvent_*` and the 
identically-broken `createdAssetEvent_*` (used by the Task Instance 
asset-events table) to match, which resolves correctly regardless of the 
consuming component's default namespace.
   
   Verified with i18next directly: the keys now render "Source Asset Event(s)" 
/ "Created Asset Event(s)" for all counts, including in the failing 
`dashboard`-default namespace context.
   
   related: #68285
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 4.8)
   
   Generated-by: Claude Code (Opus 4.8) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to