guan404ming commented on code in PR #71073:
URL: https://github.com/apache/airflow/pull/71073#discussion_r3763322589
##########
providers/common/ai/docs/operators/llm_branch.rst:
##########
@@ -92,9 +92,11 @@ against the downstream task IDs before branching:
:start-after: [START howto_operator_llm_branch_approval]
:end-before: [END howto_operator_llm_branch_approval]
-Rejecting the review, or letting ``approval_timeout`` expire, **fails** the
-task (``HITLRejectException`` / ``HITLTimeoutError``), so downstream tasks
-end up ``upstream_failed`` rather than skipped.
+Rejecting the review **skips the direct downstream tasks except teardowns**,
+matching
+:class:`~airflow.providers.standard.operators.hitl.ApprovalOperator`. Set
+``fail_on_reject=True`` to fail the task instead (generally discouraged).
+Letting ``approval_timeout`` expire fails the task (``HITLTimeoutError``).
Review Comment:
Thanks for the comments. I just reworded that the teardown carve-out is now
explicitly scoped to rejection, with a note that approving branches as usual so
unselected teardowns are skipped. Also updated the inheritance sentence to call
out fail_on_reject as operator-specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
