pierrejeambrun commented on code in PR #71441:
URL: https://github.com/apache/airflow/pull/71441#discussion_r3765750230
##########
airflow-ctl/src/airflowctl/api/datamodels/generated.py:
##########
@@ -533,6 +533,13 @@ class DagRunAssetReference(BaseModel):
data_interval_start: Annotated[datetime | None, Field(title="Data Interval
Start")]
data_interval_end: Annotated[datetime | None, Field(title="Data Interval
End")]
partition_key: Annotated[str | None, Field(title="Partition Key")]
+ triggering: Annotated[
+ bool | None,
+ Field(
+ description="Whether this asset event triggered the referenced dag
run. Only a run's most recent consumed asset event triggers it; earlier
consumed events are included in the run but did not trigger it.",
+ title="Triggering",
+ ),
+ ] = True
Review Comment:
It will never be 'None' it's always popupaled, either True/False. I chose
'True' default because it mimics the current behavior in case the logic is
wrong or something unexpected happens. (All events are considered triggering).
I removed the 'default' value all together which is confusing indeed, code
should set this explicitely.
##########
airflow-ctl/src/airflowctl/api/datamodels/generated.py:
##########
@@ -533,6 +533,13 @@ class DagRunAssetReference(BaseModel):
data_interval_start: Annotated[datetime | None, Field(title="Data Interval
Start")]
data_interval_end: Annotated[datetime | None, Field(title="Data Interval
End")]
partition_key: Annotated[str | None, Field(title="Partition Key")]
+ triggering: Annotated[
+ bool | None,
+ Field(
+ description="Whether this asset event triggered the referenced dag
run. Only a run's most recent consumed asset event triggers it; earlier
consumed events are included in the run but did not trigger it.",
+ title="Triggering",
+ ),
+ ] = True
Review Comment:
It will never be 'None' it's always popupaled, either True/False. I chose
'True' default because it mimics the current behavior in case the logic is
wrong or something unexpected happens. (All events are considered triggering).
I removed the 'default' value all together which is confusing indeed, code
should set this explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
