lubimow-xwf commented on code in PR #66929:
URL: https://github.com/apache/airflow/pull/66929#discussion_r3766380680
##########
providers/google/tests/system/google/cloud/gcs/example_gcs_to_sheets.py:
##########
@@ -88,7 +99,10 @@ def create_connection(connection_id: str):
create_connection_task = create_connection(connection_id=CONNECTION_ID)
create_spreadsheet = GoogleSheetsCreateSpreadsheetOperator(
- task_id="create_spreadsheet", spreadsheet=SPREADSHEET,
gcp_conn_id=CONNECTION_ID
+ task_id="create_spreadsheet",
+ spreadsheet=SPREADSHEET,
+ gcp_conn_id=CONNECTION_ID,
+ drive_id=GDRIVE_ID,
Review Comment:
if we go down this route, I would suggest we mark old unchanged tests as
deprecated and also add a way to disable them, as they won't work with service
accounts created after certain point in time (I think April 2025). let me know
what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
