Copilot commented on code in PR #71498:
URL: https://github.com/apache/airflow/pull/71498#discussion_r3766480133
##########
providers/amazon/tests/unit/amazon/aws/triggers/test_glue.py:
##########
@@ -173,11 +173,12 @@ async def test_verbose_run_success(self, mock_glue_conn,
mock_logs_conn):
@pytest.mark.asyncio
@mock.patch.object(AwsLogsHook, "get_async_conn")
@mock.patch.object(GlueJobHook, "get_async_conn")
- async def test_verbose_run_job_failed(self, mock_glue_conn,
mock_logs_conn):
+ @pytest.mark.parametrize("job_run_state", ["FAILED", "STOPPED", "TIMEOUT"])
+ async def test_verbose_run_job_failed(self, mock_glue_conn,
mock_logs_conn, job_run_state):
Review Comment:
Decorator order here differs from other provider tests that combine
parametrization with mock.patch: they typically put @pytest.mark.parametrize
above the @mock.patch decorators (so pytest sees a single parametrized test and
patch injection stays consistent). Keeping this order consistent avoids subtle
collection/signature issues and makes the argument ordering clearer (e.g.
providers/amazon/tests/unit/amazon/aws/triggers/test_redshift_data.py:169-172).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
