vincbeck commented on code in PR #70416:
URL: https://github.com/apache/airflow/pull/70416#discussion_r3766756328


##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -213,6 +213,8 @@ def __init__(
             raise ValueError(f"Capacity number {capacity!r} is invalid")
         self.queues = queues
         self.team_name = team_name
+        if job.team_name is None:
+            job.team_name = team_name

Review Comment:
   > Or we drop the constructor arg and require callers to set team_name on 
Job. Which resolution do you prefer, and would removing self.team_name be in 
the scope of this PR?
   
   I would go with that in this PR yes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to