ashb commented on code in PR #70960:
URL: https://github.com/apache/airflow/pull/70960#discussion_r3767774047
##########
providers/http/docs/connections/http.rst:
##########
@@ -47,12 +47,22 @@ Password (optional)
Host (optional)
Specify the entire url or the base of the url for the service.
+ If "Use DNS SRV Lookup" is enabled, specify the DNS SRV record name instead
+ (e.g. ``_http._tcp.example.com``) - Note the actual host and port are
resolved from DNS at
+ request time and any value set in the Port field is ignored.
+
Port (optional)
- Specify a port number if applicable.
+ Specify a port number if applicable. Ignored when SRV lookup is enabled.
Schema (optional)
Specify the service type etc: http/https.
+Use DNS SRV Lookup (optional)
+ Treat the Host field as a DNS SRV record name and resolve the target
host/port at request time.
+
+SRV Cache TTL (seconds) (optional)
Review Comment:
I can understand your reasoning, but I don't think this is right for two
reasons.
1. DNS caching is a notoriously complex thing to deal with (do you cache
poisitve, or NX/negative answers too)
2. The practical benefit of caching is very limited, because this caching
will apply to exactly one connection, which in all likely hood will just
resolve one host then make connections to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
