stephen-bracken commented on code in PR #70783:
URL: https://github.com/apache/airflow/pull/70783#discussion_r3767778437
##########
providers/fab/tests/unit/fab/auth_manager/test_fab_auth_manager.py:
##########
@@ -328,8 +329,12 @@ def test_get_fastapi_middlewares_disabled(self, flask_app,
auth_manager_with_app
"""No middleware is registered when public access is not configured."""
previous = flask_app.config.get("AUTH_ROLE_PUBLIC")
flask_app.config["AUTH_ROLE_PUBLIC"] = None
+ base_middleware = []
+ if AIRFLOW_V_3_4_PLUS:
Review Comment:
I am assuming that this change will be released in 3.4.0, which will add the
changes to `BaseAuthManager.get_fastapi_middlewares()` and the
`_get_jwt_refresh_middleware()` method - can correct as necessary.
##########
providers/fab/tests/unit/fab/auth_manager/test_fab_auth_manager.py:
##########
@@ -328,8 +329,12 @@ def test_get_fastapi_middlewares_disabled(self, flask_app,
auth_manager_with_app
"""No middleware is registered when public access is not configured."""
previous = flask_app.config.get("AUTH_ROLE_PUBLIC")
flask_app.config["AUTH_ROLE_PUBLIC"] = None
+ base_middleware = []
+ if AIRFLOW_V_3_4_PLUS:
Review Comment:
I am assuming that this change will be released in 3.4.0, which will add the
changes to `BaseAuthManager.get_fastapi_middlewares()` and the
`_get_jwt_refresh_middleware()` method - can correct the guard as necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
