ryanahamilton commented on code in PR #71554:
URL: https://github.com/apache/airflow/pull/71554#discussion_r3777144480
##########
airflow-core/src/airflow/ui/src/components/DataTable/DataTable.tsx:
##########
@@ -85,10 +101,10 @@ export const DataTable = <TData,>({
onDisplayToggleChange,
onStateChange,
previousCursor,
+ showColumnsMenu,
showDisplayToggle,
- showRowCountHeading = true,
Review Comment:
Replaced this with `hideRowCountHeading`. In general, optional boolean props
that default to `true` are a bad practice, so I inverted it to default to
`false`.
### Implementation - before:
```tsx
<DataTable showRowCountHeading={false} />
```
### Implementation - after:
```tsx
<DataTable hideRowCountHeading />
```
##########
airflow-core/src/airflow/ui/src/components/SearchBar.tsx:
##########
@@ -112,7 +112,9 @@ export const SearchBar = ({
<Input
data-testid="search-dags"
onChange={onSearchChange}
- placeholder={`${placeholder}${hotkeyDisabled ? undefined : `
(${metaKey}${translate("search.hotkey")})`}`}
+ placeholder={
+ hotkeyDisabled ? placeholder : `${placeholder}
(${metaKey}${translate("search.hotkey")})`
+ }
Review Comment:
This fix is not directly related to this PR, but I found it while testing.
It was introduced by me in [#71470
](https://github.com/apache/airflow/pull/71470) yesterday.
<img width="732" height="210" alt="Image"
src="https://github.com/user-attachments/assets/05bc6052-b1e9-4279-8584-13b366946342";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
