1fanwang commented on issue #66800:
URL: https://github.com/apache/airflow/issues/66800#issuecomment-5284531383
Closing — the histograms aren't needed.
The collision is a missing dimension, not a missing instrument. Airflow
builds the meter provider with `Resource.create()`, which merges
`OTEL_RESOURCE_ATTRIBUTES`, so giving each scheduler a distinct
`service.instance.id` already makes the per-scheduler samples separate series:
```
airflow.pool.open_slots{service.instance.id=scheduler-a,
pool_name=default_pool} = 128
airflow.pool.open_slots{service.instance.id=scheduler-b,
pool_name=default_pool} = 126
```
`min by (pool_name)` then recovers the same value the histogram was meant to
provide, for every gauge rather than the five pool ones, with no new metric
names to support and no slot counts riding the timer primitive.
The real gap was documentation — the metrics docs never mentioned replicas
at all. https://github.com/apache/airflow/pull/71564 covers it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
